Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4524] Fix incorrect field names in view for Mark Success/Failure #5486

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

alrolorojas
Copy link
Contributor

@alrolorojas alrolorojas commented Jun 26, 2019

Another mistake that wasn't caught from #5039 - I renamed the fields
in the template (to be unique) but didn't update the view

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4524
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

Another mistake that wasn't caught from #5039 - I renamed the fields
in the template (to be unique) but didn't update the view

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • Passes flake8

/cc @albertomsp

…lure

Another mistake that wasn't caught from apache#5039 - I renamed the fields
in the template (to be unique) but didn't update the view
@ashb ashb merged commit 6afb12f into apache:master Jun 26, 2019
@ashb
Copy link
Member

ashb commented Jun 26, 2019

(Yes I merged this without waiting for travis. I tested this locally.)

ashb pushed a commit that referenced this pull request Jun 27, 2019
…lure (#5486)

Another mistake that wasn't caught from #5039 - we renamed the fields
in the template (to be unique) but didn't update the view

(cherry picked from commit 6afb12f)
ashb pushed a commit to ashb/airflow that referenced this pull request Jun 27, 2019
…lure (apache#5486)

Another mistake that wasn't caught from apache#5039 - we renamed the fields
in the template (to be unique) but didn't update the view

(cherry picked from commit 6afb12f)
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
…lure (apache#5486)

Another mistake that wasn't caught from apache#5039 - we renamed the fields
in the template (to be unique) but didn't update the view
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
…lure (apache#5486)

Another mistake that wasn't caught from apache#5039 - we renamed the fields
in the template (to be unique) but didn't update the view
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
…lure (apache#5486)

Another mistake that wasn't caught from apache#5039 - we renamed the fields
in the template (to be unique) but didn't update the view

(cherry picked from commit 6afb12f)
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 14, 2019
…lure (apache#5486)

Another mistake that wasn't caught from apache#5039 - we renamed the fields
in the template (to be unique) but didn't update the view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants